|
|
|
library ieee;
|
|
|
|
use ieee.std_logic_1164.all;
|
|
|
|
|
|
|
|
library work;
|
|
|
|
use work.common.all;
|
|
|
|
|
|
|
|
entity control is
|
|
|
|
generic (
|
|
|
|
EX1_BYPASS : boolean := true;
|
|
|
|
PIPELINE_DEPTH : natural := 3
|
|
|
|
);
|
|
|
|
port (
|
|
|
|
clk : in std_ulogic;
|
|
|
|
rst : in std_ulogic;
|
|
|
|
|
|
|
|
complete_in : in instr_tag_t;
|
|
|
|
valid_in : in std_ulogic;
|
core: Implement quadword loads and stores
This implements the lq, stq, lqarx and stqcx. instructions.
These instructions all access two consecutive GPRs; for example the
"lq %r6,0(%r3)" instruction will load the doubleword at the address
in R3 into R7 and the doubleword at address R3 + 8 into R6. To cope
with having two GPR sources or destinations, the instruction gets
repeated at the decode2 stage, that is, for each lq/stq/lqarx/stqcx.
coming in from decode1, two instructions get sent out to execute1.
For these instructions, the RS or RT register gets modified on one
of the iterations by setting the LSB of the register number. In LE
mode, the first iteration uses RS|1 or RT|1 and the second iteration
uses RS or RT. In BE mode, this is done the other way around. In
order for decode2 to know what endianness is currently in use, we
pass the big_endian flag down from icache through decode1 to decode2.
This is always in sync with what execute1 is using because only rfid
or an interrupt can change MSR[LE], and those operations all cause
a flush and redirect.
There is now an extra column in the decode tables in decode1 to
indicate whether the instruction needs to be repeated. Decode1 also
enforces the rule that lq with RT = RT and lqarx with RA = RT or
RB = RT are illegal.
Decode2 now passes a 'repeat' flag and a 'second' flag to execute1,
and execute1 passes them on to loadstore1. The 'repeat' flag is set
for both iterations of a repeated instruction, and 'second' is set
on the second iteration. Execute1 does not take asynchronous or
trace interrupts on the second iteration of a repeated instruction.
Loadstore1 uses 'next_addr' for the second iteration of a repeated
load/store so that we access the second doubleword of the memory
operand. Thus loadstore1 accesses the doublewords in increasing
memory order. For 16-byte loads this means that the first iteration
writes GPR RT|1. It is possible that RA = RT|1 (this is a legal
but non-preferred form), meaning that if the memory operand was
misaligned, the first iteration would overwrite RA but then the
second iteration might take a page fault, leading to corrupted state.
To avoid that possibility, 16-byte loads in LE mode take an
alignment interrupt if the operand is not 16-byte aligned. (This
is the case anyway for lqarx, and we enforce it for lq as well.)
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
4 years ago
|
|
|
repeated : in std_ulogic;
|
|
|
|
flush_in : in std_ulogic;
|
|
|
|
busy_in : in std_ulogic;
|
|
|
|
deferred : in std_ulogic;
|
|
|
|
sgl_pipe_in : in std_ulogic;
|
|
|
|
stop_mark_in : in std_ulogic;
|
|
|
|
|
|
|
|
gpr_write_valid_in : in std_ulogic;
|
|
|
|
gpr_write_in : in gspr_index_t;
|
|
|
|
|
|
|
|
gpr_a_read_valid_in : in std_ulogic;
|
|
|
|
gpr_a_read_in : in gspr_index_t;
|
|
|
|
|
|
|
|
gpr_b_read_valid_in : in std_ulogic;
|
|
|
|
gpr_b_read_in : in gspr_index_t;
|
|
|
|
|
|
|
|
gpr_c_read_valid_in : in std_ulogic;
|
|
|
|
gpr_c_read_in : in gspr_index_t;
|
|
|
|
|
|
|
|
execute_next_tag : in instr_tag_t;
|
|
|
|
execute_next_cr_tag : in instr_tag_t;
|
|
|
|
execute2_next_tag : in instr_tag_t;
|
|
|
|
execute2_next_cr_tag : in instr_tag_t;
|
|
|
|
|
|
|
|
cr_read_in : in std_ulogic;
|
|
|
|
cr_write_in : in std_ulogic;
|
|
|
|
|
|
|
|
valid_out : out std_ulogic;
|
|
|
|
stall_out : out std_ulogic;
|
|
|
|
stopped_out : out std_ulogic;
|
|
|
|
|
|
|
|
gpr_bypass_a : out std_ulogic_vector(1 downto 0);
|
|
|
|
gpr_bypass_b : out std_ulogic_vector(1 downto 0);
|
|
|
|
gpr_bypass_c : out std_ulogic_vector(1 downto 0);
|
|
|
|
cr_bypass : out std_ulogic_vector(1 downto 0);
|
|
|
|
|
|
|
|
instr_tag_out : out instr_tag_t
|
|
|
|
);
|
|
|
|
end entity control;
|
|
|
|
|
|
|
|
architecture rtl of control is
|
|
|
|
type state_type is (IDLE, WAIT_FOR_PREV_TO_COMPLETE, WAIT_FOR_CURR_TO_COMPLETE);
|
|
|
|
|
|
|
|
type reg_internal_type is record
|
|
|
|
state : state_type;
|
|
|
|
outstanding : integer range -1 to PIPELINE_DEPTH+2;
|
|
|
|
end record;
|
|
|
|
constant reg_internal_init : reg_internal_type := (state => IDLE, outstanding => 0);
|
|
|
|
|
|
|
|
signal r_int, rin_int : reg_internal_type := reg_internal_init;
|
|
|
|
|
|
|
|
signal gpr_write_valid : std_ulogic;
|
|
|
|
signal cr_write_valid : std_ulogic;
|
|
|
|
|
|
|
|
type tag_register is record
|
|
|
|
wr_gpr : std_ulogic;
|
|
|
|
reg : gspr_index_t;
|
|
|
|
recent : std_ulogic;
|
|
|
|
wr_cr : std_ulogic;
|
|
|
|
end record;
|
|
|
|
|
|
|
|
type tag_regs_array is array(tag_number_t) of tag_register;
|
|
|
|
signal tag_regs : tag_regs_array;
|
|
|
|
|
|
|
|
signal instr_tag : instr_tag_t;
|
|
|
|
|
|
|
|
signal gpr_tag_stall : std_ulogic;
|
|
|
|
signal cr_tag_stall : std_ulogic;
|
|
|
|
|
|
|
|
signal curr_tag : tag_number_t;
|
|
|
|
signal next_tag : tag_number_t;
|
|
|
|
|
|
|
|
signal curr_cr_tag : tag_number_t;
|
|
|
|
|
|
|
|
begin
|
|
|
|
control0: process(clk)
|
|
|
|
begin
|
|
|
|
if rising_edge(clk) then
|
|
|
|
assert rin_int.outstanding >= 0 and rin_int.outstanding <= (PIPELINE_DEPTH+1)
|
|
|
|
report "Outstanding bad " & integer'image(rin_int.outstanding) severity failure;
|
|
|
|
r_int <= rin_int;
|
|
|
|
for i in tag_number_t loop
|
|
|
|
if rst = '1' or flush_in = '1' then
|
|
|
|
tag_regs(i).wr_gpr <= '0';
|
|
|
|
tag_regs(i).wr_cr <= '0';
|
|
|
|
else
|
|
|
|
if complete_in.valid = '1' and i = complete_in.tag then
|
|
|
|
tag_regs(i).wr_gpr <= '0';
|
|
|
|
tag_regs(i).wr_cr <= '0';
|
|
|
|
report "tag " & integer'image(i) & " not valid";
|
|
|
|
end if;
|
Add a second execute stage to the pipeline
This adds a second execute stage to the pipeline, in order to match up
the length of the pipeline through loadstore and dcache with the
length through execute1. This will ultimately enable us to get rid of
the 1-cycle bubble that we currently have when issuing ALU
instructions after one or more LSU instructions.
Most ALU instructions execute in the first stage, except for
count-zeroes and popcount instructions (which take two cycles and do
some of their work in the second stage) and mfspr/mtspr to "slow" SPRs
(TB, DEC, PVR, LOGA/LOGD, CFAR). Multiply and divide/mod instructions
take several cycles but the instruction stays in the first stage (ex1)
and ex1.busy is asserted until the operation is complete.
There is currently a bypass from the first stage but not the second
stage. Performance is down somewhat because of that and because this
doesn't yet eliminate the bubble between LSU and ALU instructions.
The forwarding of XER common bits has been changed somewhat because
now there is another pipeline stage between ex1 and the committed
state in cr_file. The simplest thing for now is to record the last
value written and use that, unless there has been a flush, in which
case the committed state (obtained via e_in.xerc) is used.
Note that this fixes what was previously a benign bug in control.vhdl,
where it was possible for control to forget an instructions dependency
on a value from a previous instruction (a GPR or the CR) if this
instruction writes the value and the instruction gets to the point
where it could issue but is blocked by the busy signal from execute1.
In that situation, control may incorrectly not indicate that a bypass
should be used. That didn't matter previously because, for ALU and
FPU instructions, there was only one previous instruction in flight
and once the current instruction could issue, the previous instruction
was completing and the correct value would be obtained from
register_file or cr_file. For loadstore instructions there could be
two being executed, but because there are no bypass paths, failing to
indicate use of a bypass path is fine.
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2 years ago
|
|
|
if instr_tag.valid = '1' and gpr_write_valid = '1' and
|
|
|
|
tag_regs(i).reg = gpr_write_in then
|
|
|
|
tag_regs(i).recent <= '0';
|
|
|
|
if tag_regs(i).recent = '1' and tag_regs(i).wr_gpr = '1' then
|
|
|
|
report "tag " & integer'image(i) & " not recent";
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
if instr_tag.valid = '1' and i = instr_tag.tag then
|
|
|
|
tag_regs(i).wr_gpr <= gpr_write_valid;
|
|
|
|
tag_regs(i).reg <= gpr_write_in;
|
|
|
|
tag_regs(i).recent <= gpr_write_valid;
|
|
|
|
tag_regs(i).wr_cr <= cr_write_valid;
|
|
|
|
if gpr_write_valid = '1' then
|
|
|
|
report "tag " & integer'image(i) & " valid for gpr " & to_hstring(gpr_write_in);
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
end loop;
|
|
|
|
if rst = '1' then
|
|
|
|
curr_tag <= 0;
|
|
|
|
curr_cr_tag <= 0;
|
|
|
|
else
|
|
|
|
curr_tag <= next_tag;
|
Add a second execute stage to the pipeline
This adds a second execute stage to the pipeline, in order to match up
the length of the pipeline through loadstore and dcache with the
length through execute1. This will ultimately enable us to get rid of
the 1-cycle bubble that we currently have when issuing ALU
instructions after one or more LSU instructions.
Most ALU instructions execute in the first stage, except for
count-zeroes and popcount instructions (which take two cycles and do
some of their work in the second stage) and mfspr/mtspr to "slow" SPRs
(TB, DEC, PVR, LOGA/LOGD, CFAR). Multiply and divide/mod instructions
take several cycles but the instruction stays in the first stage (ex1)
and ex1.busy is asserted until the operation is complete.
There is currently a bypass from the first stage but not the second
stage. Performance is down somewhat because of that and because this
doesn't yet eliminate the bubble between LSU and ALU instructions.
The forwarding of XER common bits has been changed somewhat because
now there is another pipeline stage between ex1 and the committed
state in cr_file. The simplest thing for now is to record the last
value written and use that, unless there has been a flush, in which
case the committed state (obtained via e_in.xerc) is used.
Note that this fixes what was previously a benign bug in control.vhdl,
where it was possible for control to forget an instructions dependency
on a value from a previous instruction (a GPR or the CR) if this
instruction writes the value and the instruction gets to the point
where it could issue but is blocked by the busy signal from execute1.
In that situation, control may incorrectly not indicate that a bypass
should be used. That didn't matter previously because, for ALU and
FPU instructions, there was only one previous instruction in flight
and once the current instruction could issue, the previous instruction
was completing and the correct value would be obtained from
register_file or cr_file. For loadstore instructions there could be
two being executed, but because there are no bypass paths, failing to
indicate use of a bypass path is fine.
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2 years ago
|
|
|
if instr_tag.valid = '1' and cr_write_valid = '1' then
|
|
|
|
curr_cr_tag <= instr_tag.tag;
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
end process;
|
|
|
|
|
|
|
|
control_hazards : process(all)
|
|
|
|
variable gpr_stall : std_ulogic;
|
|
|
|
variable tag_a : instr_tag_t;
|
|
|
|
variable tag_b : instr_tag_t;
|
|
|
|
variable tag_c : instr_tag_t;
|
|
|
|
variable tag_s : instr_tag_t;
|
|
|
|
variable tag_t : instr_tag_t;
|
|
|
|
variable incr_tag : tag_number_t;
|
|
|
|
variable byp_a : std_ulogic_vector(1 downto 0);
|
|
|
|
variable byp_b : std_ulogic_vector(1 downto 0);
|
|
|
|
variable byp_c : std_ulogic_vector(1 downto 0);
|
|
|
|
variable tag_cr : instr_tag_t;
|
|
|
|
variable byp_cr : std_ulogic_vector(1 downto 0);
|
|
|
|
begin
|
|
|
|
tag_a := instr_tag_init;
|
|
|
|
for i in tag_number_t loop
|
|
|
|
if tag_regs(i).wr_gpr = '1' and tag_regs(i).recent = '1' and tag_regs(i).reg = gpr_a_read_in then
|
|
|
|
tag_a.valid := gpr_a_read_valid_in;
|
|
|
|
tag_a.tag := i;
|
|
|
|
end if;
|
|
|
|
end loop;
|
|
|
|
if tag_match(tag_a, complete_in) then
|
|
|
|
tag_a.valid := '0';
|
|
|
|
end if;
|
|
|
|
tag_b := instr_tag_init;
|
|
|
|
for i in tag_number_t loop
|
|
|
|
if tag_regs(i).wr_gpr = '1' and tag_regs(i).recent = '1' and tag_regs(i).reg = gpr_b_read_in then
|
|
|
|
tag_b.valid := gpr_b_read_valid_in;
|
|
|
|
tag_b.tag := i;
|
|
|
|
end if;
|
|
|
|
end loop;
|
|
|
|
if tag_match(tag_b, complete_in) then
|
|
|
|
tag_b.valid := '0';
|
|
|
|
end if;
|
|
|
|
tag_c := instr_tag_init;
|
|
|
|
for i in tag_number_t loop
|
|
|
|
if tag_regs(i).wr_gpr = '1' and tag_regs(i).recent = '1' and tag_regs(i).reg = gpr_c_read_in then
|
|
|
|
tag_c.valid := gpr_c_read_valid_in;
|
|
|
|
tag_c.tag := i;
|
|
|
|
end if;
|
|
|
|
end loop;
|
|
|
|
if tag_match(tag_c, complete_in) then
|
|
|
|
tag_c.valid := '0';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
byp_a := "00";
|
|
|
|
if EX1_BYPASS and tag_match(execute_next_tag, tag_a) then
|
|
|
|
byp_a := "10";
|
|
|
|
elsif EX1_BYPASS and tag_match(execute2_next_tag, tag_a) then
|
|
|
|
byp_a := "11";
|
|
|
|
end if;
|
|
|
|
byp_b := "00";
|
|
|
|
if EX1_BYPASS and tag_match(execute_next_tag, tag_b) then
|
|
|
|
byp_b := "10";
|
|
|
|
elsif EX1_BYPASS and tag_match(execute2_next_tag, tag_b) then
|
|
|
|
byp_b := "11";
|
|
|
|
end if;
|
|
|
|
byp_c := "00";
|
|
|
|
if EX1_BYPASS and tag_match(execute_next_tag, tag_c) then
|
|
|
|
byp_c := "10";
|
|
|
|
elsif EX1_BYPASS and tag_match(execute2_next_tag, tag_c) then
|
|
|
|
byp_c := "11";
|
|
|
|
end if;
|
|
|
|
|
|
|
|
gpr_bypass_a <= byp_a;
|
|
|
|
gpr_bypass_b <= byp_b;
|
|
|
|
gpr_bypass_c <= byp_c;
|
|
|
|
|
|
|
|
gpr_tag_stall <= (tag_a.valid and not byp_a(1)) or
|
|
|
|
(tag_b.valid and not byp_b(1)) or
|
|
|
|
(tag_c.valid and not byp_c(1));
|
|
|
|
|
|
|
|
incr_tag := curr_tag;
|
|
|
|
instr_tag.tag <= curr_tag;
|
|
|
|
instr_tag.valid <= valid_out and not deferred;
|
|
|
|
if instr_tag.valid = '1' then
|
|
|
|
incr_tag := (curr_tag + 1) mod TAG_COUNT;
|
|
|
|
end if;
|
|
|
|
next_tag <= incr_tag;
|
|
|
|
instr_tag_out <= instr_tag;
|
|
|
|
|
|
|
|
-- CR hazards
|
|
|
|
tag_cr.tag := curr_cr_tag;
|
|
|
|
tag_cr.valid := cr_read_in and tag_regs(curr_cr_tag).wr_cr;
|
|
|
|
if tag_match(tag_cr, complete_in) then
|
|
|
|
tag_cr.valid := '0';
|
|
|
|
end if;
|
|
|
|
byp_cr := "00";
|
|
|
|
if EX1_BYPASS and tag_match(execute_next_cr_tag, tag_cr) then
|
|
|
|
byp_cr := "10";
|
|
|
|
elsif EX1_BYPASS and tag_match(execute2_next_cr_tag, tag_cr) then
|
|
|
|
byp_cr := "11";
|
|
|
|
end if;
|
|
|
|
|
|
|
|
cr_bypass <= byp_cr;
|
|
|
|
cr_tag_stall <= tag_cr.valid and not byp_cr(1);
|
|
|
|
end process;
|
|
|
|
|
|
|
|
control1 : process(all)
|
|
|
|
variable v_int : reg_internal_type;
|
|
|
|
variable valid_tmp : std_ulogic;
|
|
|
|
variable stall_tmp : std_ulogic;
|
|
|
|
begin
|
|
|
|
v_int := r_int;
|
|
|
|
|
|
|
|
-- asynchronous
|
|
|
|
valid_tmp := valid_in and not flush_in;
|
|
|
|
stall_tmp := '0';
|
|
|
|
|
|
|
|
if flush_in = '1' then
|
|
|
|
v_int.outstanding := 0;
|
|
|
|
elsif complete_in.valid = '1' then
|
|
|
|
v_int.outstanding := r_int.outstanding - 1;
|
|
|
|
end if;
|
|
|
|
if r_int.outstanding >= PIPELINE_DEPTH + 1 then
|
|
|
|
valid_tmp := '0';
|
|
|
|
stall_tmp := '1';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
if rst = '1' then
|
|
|
|
gpr_write_valid <= '0';
|
|
|
|
cr_write_valid <= '0';
|
|
|
|
v_int := reg_internal_init;
|
|
|
|
valid_tmp := '0';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
-- Handle debugger stop
|
|
|
|
stopped_out <= '0';
|
|
|
|
if stop_mark_in = '1' and v_int.outstanding = 0 then
|
|
|
|
stopped_out <= '1';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
-- state machine to handle instructions that must be single
|
|
|
|
-- through the pipeline.
|
|
|
|
case r_int.state is
|
|
|
|
when IDLE =>
|
|
|
|
if valid_tmp = '1' then
|
|
|
|
if (sgl_pipe_in = '1') then
|
|
|
|
if v_int.outstanding /= 0 then
|
|
|
|
v_int.state := WAIT_FOR_PREV_TO_COMPLETE;
|
|
|
|
stall_tmp := '1';
|
|
|
|
else
|
|
|
|
-- send insn out and wait on it to complete
|
|
|
|
v_int.state := WAIT_FOR_CURR_TO_COMPLETE;
|
|
|
|
end if;
|
|
|
|
else
|
|
|
|
-- let it go out if there are no GPR or CR hazards
|
|
|
|
stall_tmp := gpr_tag_stall or cr_tag_stall;
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
|
|
|
|
when WAIT_FOR_PREV_TO_COMPLETE =>
|
|
|
|
if v_int.outstanding = 0 then
|
|
|
|
-- send insn out and wait on it to complete
|
|
|
|
v_int.state := WAIT_FOR_CURR_TO_COMPLETE;
|
|
|
|
else
|
|
|
|
stall_tmp := '1';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
when WAIT_FOR_CURR_TO_COMPLETE =>
|
|
|
|
if v_int.outstanding = 0 then
|
|
|
|
v_int.state := IDLE;
|
|
|
|
-- XXX Don't replicate this
|
|
|
|
if valid_tmp = '1' then
|
|
|
|
if (sgl_pipe_in = '1') then
|
|
|
|
if v_int.outstanding /= 0 then
|
|
|
|
v_int.state := WAIT_FOR_PREV_TO_COMPLETE;
|
|
|
|
stall_tmp := '1';
|
|
|
|
else
|
|
|
|
-- send insn out and wait on it to complete
|
|
|
|
v_int.state := WAIT_FOR_CURR_TO_COMPLETE;
|
|
|
|
end if;
|
|
|
|
else
|
|
|
|
-- let it go out if there are no GPR or CR hazards
|
|
|
|
stall_tmp := gpr_tag_stall or cr_tag_stall;
|
|
|
|
end if;
|
|
|
|
end if;
|
|
|
|
else
|
|
|
|
stall_tmp := '1';
|
|
|
|
end if;
|
|
|
|
end case;
|
|
|
|
|
|
|
|
if stall_tmp = '1' then
|
|
|
|
valid_tmp := '0';
|
|
|
|
end if;
|
|
|
|
|
|
|
|
gpr_write_valid <= gpr_write_valid_in and valid_tmp;
|
|
|
|
cr_write_valid <= cr_write_in and valid_tmp;
|
|
|
|
|
|
|
|
if valid_tmp = '1' and deferred = '0' then
|
|
|
|
v_int.outstanding := v_int.outstanding + 1;
|
|
|
|
end if;
|
|
|
|
|
|
|
|
-- update outputs
|
|
|
|
valid_out <= valid_tmp;
|
|
|
|
stall_out <= stall_tmp or deferred;
|
|
|
|
|
|
|
|
-- update registers
|
|
|
|
rin_int <= v_int;
|
|
|
|
end process;
|
|
|
|
end;
|